Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/helper: remove timeout for fetch diagnose from info pd (#11352) #11383

Merged
merged 3 commits into from
Jul 25, 2019
Merged

store/helper: remove timeout for fetch diagnose from info pd (#11352) #11383

merged 3 commits into from
Jul 25, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jul 23, 2019

cherry-pick #11352 to release-3.0

@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 23, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Jul 23, 2019
Merged
zz-jason
zz-jason reviewed Jul 23, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested a review from winoros July 23, 2019 06:38
@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2019
@lysu
Copy link
Contributor

lysu commented Jul 23, 2019

/run-all-tests

winoros
winoros reviewed Jul 24, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
please fix the tests

@lysu
Copy link
Contributor

lysu commented Jul 25, 2019

/run-all-tests

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 25, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 25, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 25, 2019

Ready to merge!

@sre-bot sre-bot merged commit a79a86e into pingcap:release-3.0 Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/server status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @lysu @zz-jason @winoros